Notes on Style

Notes on Style

Notes on Style

Notes on Style

Minimize Horizontal Scrolling

Split lines (use the underscore!) and indent. My rationale is that horizontal scrolling takes too long. You want to be able to scan through your code quickly. You also want to be able to view code modules side-by-side, which ties into another upcoming post (TODO…) regarding code modularity – specifically, if your procedure is going to be lengthy, consider placing it in its own module, and ALWAYS use a naming convention. This applies to variables and modules. Pick a convention and stick to it. The VBE (Visual Basic Editor) has split screen, but that only works with a horizontal separator. It is helpful to be able to view code side-by-side, particularly if you’re writing class definitions that may have similar implementations. If your lines are short, you can view more modules side-by-side.

The screenshot illustrates the following conventions that I like to use:

Split line after open parentheses and each parameter

This includes the first line of any procedure definition (Sub, Property, Function).
Each parameter should be on its own line. Be mindful of proper syntax with regards to commas. This will drive you crazy if you’re not careful. The debugger is your friend. So, for instance:

Function MyFunction( _
  strParamOne as String, _
  strParamTwo as String, _
  intParamCounter as Integer, _
  strLastParam as String _
)

Note the comma-space-underscore syntax for all parameters except the last one. The debugger will yell at you about this, but do yourself a favor and form the habit.

Split line after Dim statement when declaring multiple variables

This ties into my convention for splitting lines after multiple parameters. It may not be necessary for single parameters, but consider that VBA permits you to use up to 1,203 characters to name your variables. That enables you to be descriptive with your variable names, which you should be, because someone will probably have to decipher that code of yours eventually – and it might just be you. NEVER use non-descriptive variable names such as a, b, c or x, y, z. Just don’t do it. So, conserve your horizontal space on each line.  For instance:

Dim strMyVariable as String

Keeping a single variable declaration on one line may be acceptable. It’s up to you. Just make a decision and stick to it. If you have a long variable name, you might want to conserve some space like this:

Dim _
strWorksheetNameConcatenatedFromSourceWorkbook as String

When declaring multiple variables, I like to give them each their own indented line:

Dim _
  strMyFirstVariable as String, _
  strMySecondVariable as String, _
  intMyThirdVariable as Integer, _
  strMyLastVariable as String

Split lengthy strings into separate lines

Your mileage may vary on this, but I think 80 characters is a good limit to set. Split your strings and concatenate them with an ampersand, then use ampersand-space-underscore to split your lines:

strMyLongString = _
  "This will be a " & _
  "run-on sentence with " & _
  "a few variables thrown in " & _
  "here: " & _
  strMyFirstConcatenatedStringElement & _
  " and here: " & _
  strMySecondConcatenatedStringElement & _
  " to properly illustrate my " & _
  "point."

Note that there is a limit on VBA line continuations (see Microsoft Office Dev Center Article). Per the specs: Your code should have no more than 25 physical lines joined with line-continuation characters or more than 24 consecutive line-continuation characters in a single line. Make some of the constituent lines physically longer to reduce the number of line-continuation characters needed, or break the construct into more than one statement.

Leave a Reply

Your email address will not be published. Required fields are marked *